Fixes required for Solang#10
Merged
dmakarov merged 2 commits intoanza-xyz:solana-rustc/11.0-2021-01-05from Apr 13, 2021
Merged
Conversation
dmakarov
reviewed
Apr 13, 2021
dmakarov
reviewed
Apr 13, 2021
|
I add the prefix |
Every time Solang tries to link a web-assembly file in-process, the linker re-inits llvm which is not thread-safe with the rest of solang. Signed-off-by: Sean Young <sean@mess.org>
Author
|
I've updated the commit messages. |
|
LGTM. Let's wait for the CI checks to finish (it'll take some time), and then this can be merged. Thank you. |
Signed-off-by: Sean Young <sean@mess.org>
Author
|
Looks like all CI checks have passed |
dmakarov
pushed a commit
that referenced
this pull request
Apr 13, 2021
* [SOL] Make lld thread-safe with llvm when used in-process Every time Solang tries to link a web-assembly file in-process, the linker re-inits llvm which is not thread-safe with the rest of solang. Signed-off-by: Sean Young <sean@mess.org> * [SOL][BPF] Enable the _ExtInt extension on the BPF Target for Solana Signed-off-by: Sean Young <sean@mess.org>
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 9, 2026
…izer (llvm#173734) This patch extends the AArch64ConditionOptimizer pass to handle CSINC instructions within a single basic block, complementing the existing cross-block branch optimization. The optimization finds two CMP+CSINC pairs comparing the same register with immediates differing by 1, and adjusts one comparison to enable CSE to eliminate the redundant CMP instruction. Example transformation: ``` cmp w8, anza-xyz#10 csinc w9, w0, w1, gt ; w9 = (w8 > 10) ? w0 : w1+1 cmp w8, anza-xyz#9 ; Removed by CSE after adjustment csinc w10, w0, w1, gt ; w10 = (w8 > 9) ? w0 : w1+1 ``` After optimization: ``` cmp w8, anza-xyz#10 csinc w9, w0, w1, gt ; w9 = (w8 > 10) ? w0 : w1+1 csinc w10, w0, w1, ge ; w10 = (w8 >= 10) ? w0 : w1+1 ``` The existing cross-block logic has also been extracted into its own method. Any feedback on code quality and better practices is highly welcome. Co-authored-by: Hussam Alhassan <hsm.link@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.